Adding backcompat shim for BaseNotifier#50340
Merged
potiuk merged 3 commits intoapache:mainfrom May 9, 2025
Merged
Conversation
ashb
approved these changes
May 8, 2025
kaxil
approved these changes
May 8, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Pre-approving since it is a simple change
kaxil
added
the
backport-to-v3-1-test
potiuk
reviewed
May 8, 2025
gopidesupavan
approved these changes
May 9, 2025
uranusjr
approved these changes
May 9, 2025
potiuk
approved these changes
May 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2025
* Adding backcompat shim for BaseNotifier * Adding deprecation warning too * using deprecation properly (cherry picked from commit bf99522) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 9, 2025
* Adding backcompat shim for BaseNotifier * Adding deprecation warning too * using deprecation properly (cherry picked from commit bf99522) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
May 9, 2025
2 tasks
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to import BaseNotifier from the older path in core reported in
We should maintain backcompat to allow seamless migration for end users.
Also interestingly the shorthand
from airflow.sdk import BaseNotifierdidn;t work. Fixed it in the PR too^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.